We're now doing bikers file for Docker file he's on p p during the standard p p Apache and has all of 1
his app gets in one that looks great. 2
Also you'll notice with P HP that in order to configure different things and to add extensions in the 3
PSP you have to use special commands in Docker. 4
So he's doing that that's great. 5
To add all these in I might hard code especially these libraries right here. 6
Definitely hard code the versions because that's exactly how I got bit on my p HP production project 7
was I think was it was you know a Postgres driver or a mongo driver or something had a bug in it and 8
it updated to not even a major release it just updated to a minor release in one of our image builds 9
and crashed production so definitely hard code that lets see we've got some pear stuff or pickle stuff 10
rather we've got composed installer and it looks like you're getting whatever version there's the latest 11
version of composer and I know lately in the last couple of years composer has been pretty rapid on 12
the versions but I might hard code this if you're super concerned about versions I might set an enviroment 13
variable to top to get that and then put it down here. 14
The rest of that looks good. 15
And then you've got down here you're setting some limits so your looks like here your hard coding stuff 16
inside of Zend and inside of P P itself. 17
So if you ever need to change those. 18
Great but I find that you know sometimes in my dev environment I don't want to log these limits and 19
settings are really high but I want them really high in production so I'll often set these as environment 20
variables you've probably seen that in my PSP example repo and then we get down here to Drupal and we 21
set the Drupal version and we installed Drupal so it looks like don't know if that's the end of the 22
file or if it didn't all make it 23
yeah. 24
So you've got Drupal at the end there. 25
I would take that as Drupal versions throw them all the way to the top right below the from that. 26
That way I know what all versions I'm installing and that does. 27
I keep those at the top it's easier to read when they're all the way at the top. 28
At first it always makes sense to put the version with the block that you're using it in but as you 29
get more and more versions of things like versions of composer version of Drupal all that stuff. 30
Yeah 31
cool stuff. 32
And so yeah. 33
And you're doing the curl right. 34
All here you're cleaning up after yourself. 35
It looks great it looks great there and you're choking as usual. 36
We got a show on our directories and good stuff. 37
I think overall this is a great doctor file. 38
It's got a lot going on. 39
I don't know if you've considered separating out Dev dependencies from production dependencies if you 40
have to deal with that. 41
You might consider multi-stage in order to do that in production. 42
But other than that it looks legit. 43
Catch up.